Skip to content

cloud: add private link firewall rules for clusters on AWS and Alibaba Cloud#22650

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.5from
hfxsd:connect-via-ali-and-aws
Apr 1, 2026
Merged

cloud: add private link firewall rules for clusters on AWS and Alibaba Cloud#22650
ti-chi-bot[bot] merged 7 commits intopingcap:release-8.5from
hfxsd:connect-via-ali-and-aws

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Mar 30, 2026 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the contribution This PR is from a community contributor. label Mar 30, 2026
@hfxsd hfxsd self-assigned this Mar 30, 2026
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2026
@hfxsd hfxsd added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new step, 'Authorize your private endpoint in TiDB Cloud', to the documentation for setting up private endpoint connections on Alibaba Cloud and TiDB Cloud Serverless. The review feedback identifies several issues: a copy-paste error referencing AWS in the Alibaba Cloud guide, inconsistent anchor links and text in the tables of contents, and heading punctuation that violates the repository style guide.

Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
@hfxsd hfxsd requested a review from OliverATajiki March 30, 2026 06:13
@hfxsd @gemini-code-assist
Apply suggestions from code review
644e36a 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2026
@hfxsd hfxsd requested a review from qiancai March 30, 2026 06:27
sanshuiyijing
sanshuiyijing approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown

@sanshuiyijing sanshuiyijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 30, 2026

@sanshuiyijing: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qiancai
qiancai reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
qiancai
qiancai reviewed Mar 30, 2026
View reviewed changes
Comment thread tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md Outdated
qiancai
qiancai reviewed Mar 30, 2026
View reviewed changes
Comment thread tidb-cloud/set-up-private-endpoint-connections-serverless.md Outdated
hfxsd and others added 2 commits March 30, 2026 15:10
@hfxsd @qiancai
Apply suggestions from code review
18f9a17 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd @qiancai
Apply suggestions from code review
a64b05e 
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Mar 30, 2026

/retest

@hfxsd hfxsd added the lgtm label Mar 31, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 1, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 1, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 1, 2026

/retest

1 similar comment
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 1, 2026

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 6d273a5 into pingcap:release-8.5 Apr 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@OliverATajiki OliverATajiki Awaiting requested review from OliverATajiki

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@sanshuiyijing sanshuiyijing sanshuiyijing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hfxsd @sanshuiyijing @qiancai